Improve monitor section in the last blog post #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for openbuildservice ready! Built with commit 76196b3 |
krig
reviewed
Feb 19, 2019
krig
reviewed
Feb 19, 2019
dmarcoux
suggested changes
Feb 19, 2019
saraycp
reviewed
Feb 19, 2019
|
On Dienstag, 19. Februar 2019, 10:43:44 CET Dany Marcoux wrote:
dmarcoux commented on this pull request.
> @@ -26,12 +26,14 @@ The comments from a superseded request are now under a
> tab, next to the request'
## Improvements for the Project Monitor Page
-We improved the usability of the filters.
-They previously closed whenever checking/unchecking one of their
checkboxes. -This is fixed.
-
-The datatable had rendering errors when used in combination with the
`table-sm` _Boostrap_ class due to a bug in the JavaScript library we use.
-As good open-source users, we reported it
[upstream](mkhairi/jquery-datatables#17). +In the
monitor page, we fixed a regression in performance that made that for some
projects it took too long to load.
A bit too many `that` IMHO.
You should not announce that monitor atm IMHO, it is really not usable since
it became bootstrap (I have the anonymous browser window always open to use it
since last year)
openSUSE/open-build-service#7007
…--
Adrian Schroeter
SUSE Linux Products GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany
email: [email protected]
|
We are just letting users know we worked on it in the last weeks and we are continuing working on it. It is not a last version. The issues you mention are not related with the ones that were fixed (at least not all of them). |
dmarcoux
approved these changes
Feb 19, 2019
Add some more details and mention the help we got from upstream.
saraycp
approved these changes
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some more details and mention the help we got from upstream.
Sorry I didn't add this before. I had RAM problems in my computer when trying to get the performance numbers. We decided not to mention the numbers, as this page is faster than before but still there is place for improvement and it is slower than the old one (because of the improvement in usability - Nice table with first column fixed instead of a broken table)