Remove source methods from BsRequestAction model #17314
Open
+0
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoj
added
the
DO NOT MERGE ⚠️
|
This pull request only makes sense after backfilling the |
After backfilling the `source_project_id` and `source_package_id` fields, we can rely in these associations instead of performing queries with methods.
eduardoj
force-pushed
the
refactoring/remove_bs_request_actions_source_methods
branch
from
a45c620 to
eca14da
Compare
eduardoj
removed
the
DO NOT MERGE ⚠️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After backfilling the
source_project_idandsource_package_idfields, we can rely in this associations instead of performing queries with methods.