Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports of several patches from master to 0.x-maint #1321

Draft
wants to merge 8 commits into
base: 0.x-maint
Choose a base branch
from

Conversation

dmach
Copy link
Contributor

@dmach dmach commented May 10, 2023

No description provided.

Firstyear and others added 4 commits May 4, 2023 22:00
This causes downloads to come from the api, generally on noarch packages.
However, in countries like australia, due to OBS' high latency, and poor
bandwidth, these faults can cause downloads to take more than an hour, compared
to using a local mirror which can take minutes. There is actually nothing
wrong with the packages it all, OBS just sends the wrong md5.

As a result, ignore the problem and complain about it, because OBS is broken
here, not osc, and this wastes a lot of time.
A very conservative backport of:

commit 2496b3e
Author: Daniel Mach <[email protected]>
Date:   Wed Sep 7 10:09:20 2022 +0200

    Properly handle missing ssh-keygen and ssh-add
@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 7.89% and project coverage change: -0.02 ⚠️

Comparison is base (6eb8a64) 22.11% compared to head (538c72b) 22.09%.

Additional details and impacted files
@@              Coverage Diff              @@
##           0.x-maint    #1321      +/-   ##
=============================================
- Coverage      22.11%   22.09%   -0.02%     
=============================================
  Files             27       27              
  Lines          16556    16583      +27     
=============================================
+ Hits            3661     3664       +3     
- Misses         12895    12919      +24     
Impacted Files Coverage Δ
osc/build.py 0.00% <0.00%> (ø)
osc/commandline.py 14.79% <ø> (ø)
osc/core.py 36.15% <0.00%> (-0.02%) ⬇️
osc/fetch.py 0.00% <0.00%> (ø)
osc/conf.py 31.10% <23.07%> (-0.07%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dmach dmach marked this pull request as draft May 12, 2023 06:32
Vogtinator and others added 4 commits May 23, 2023 16:08
Keep the original behaviour by default, but allow other callers to also
request reviews on e.g. declined SRs.
…view, declined)

The original behavior was that only requests in the 'review' state
were displayed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants