-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backports of several patches from master to 0.x-maint #1321
Draft
dmach
wants to merge
8
commits into
openSUSE:0.x-maint
Choose a base branch
from
dmach:0.x-backports
base: 0.x-maint
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes downloads to come from the api, generally on noarch packages. However, in countries like australia, due to OBS' high latency, and poor bandwidth, these faults can cause downloads to take more than an hour, compared to using a local mirror which can take minutes. There is actually nothing wrong with the packages it all, OBS just sends the wrong md5. As a result, ignore the problem and complain about it, because OBS is broken here, not osc, and this wastes a lot of time.
A very conservative backport of: commit 2496b3e Author: Daniel Mach <[email protected]> Date: Wed Sep 7 10:09:20 2022 +0200 Properly handle missing ssh-keygen and ssh-add
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## 0.x-maint #1321 +/- ##
=============================================
- Coverage 22.11% 22.09% -0.02%
=============================================
Files 27 27
Lines 16556 16583 +27
=============================================
+ Hits 3661 3664 +3
- Misses 12895 12919 +24
☔ View full report in Codecov by Sentry. |
Keep the original behaviour by default, but allow other callers to also request reviews on e.g. declined SRs.
…view, declined) The original behavior was that only requests in the 'review' state were displayed.
We don't use it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.