Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add timezone to publishing checklist #43

Merged
merged 4 commits into from
Dec 20, 2024
+7 −5
Merged

fix: Add timezone to publishing checklist #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1003ad5
fix: Add timezone to publishing checklist
nickevansuk Dec 20, 2024
de6b963
Update pull_request_template.md
nickevansuk Dec 20, 2024
4c4ff1c
Update validate-new-dataset.yml
nickevansuk Dec 20, 2024
c0ca7c2
Update npm-test.yml
nickevansuk Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/npm-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Use Node.js 18.x
uses: actions/setup-node@v1
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/validate-new-dataset.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,12 @@ jobs:
node-version: 18

- name: Checkout PR branch
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
path: new

- name: Checkout master branch
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
ref: master
path: old
Expand All @@ -48,7 +48,7 @@ jobs:
old_json_file: './old/singular-test.jsonld'

- name: Checkout OpenActive Test Suite
uses: actions/checkout@v2
uses: actions/checkout@v4
if: ${{ steps.dataset.outputs.url || steps.dataset-preview.outputs.url || steps.dataset-test.outputs.url }}
with:
repository: openactive/openactive-test-suite
Expand All @@ -69,7 +69,7 @@ jobs:
working-directory: tests

- name: Upload validation results as artifact upon failure
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
if: ${{ failure() && (steps.dataset.outputs.url || steps.dataset-preview.outputs.url || steps.dataset-test.outputs.url) }}
with:
name: validation-results
Expand Down
2 changes: 2 additions & 0 deletions pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,10 @@ I confirm the following:
- [ ] My open data feeds conform to one of the permissable combinations specified in https://developer.openactive.io/publishing-data/data-feeds/types-of-feed
- [ ] My open data feeds all pass the OpenActive Validator's model validation (https://validator.openactive.io/)
- [ ] My open data feeds all pass the OpenActive Validator's RPDE feed validation (https://validator.openactive.io/rpde)
- [ ] My open data feeds all pass the OpenActive Test Suite's deep validation (https://developer.openactive.io/publishing-data/data-feeds/testing-feeds#openactive-test-suite)
- [ ] My open data feeds include activity list references as specified in https://developer.openactive.io/publishing-data/activity-list-references
- [ ] My dataset site(s) each reference a GitHub Issues Board
- [ ] I have checked that the times in the feed `startDate` and `endDate` match the times on the website referenced by the `url`, and can confirm that there are no timezone issues

## Maintenance Checklist

Expand Down
Loading