Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruby version matrix to include current ruby versions #40

Merged
merged 6 commits into from
Jun 17, 2024

Conversation

kieranj
Copy link
Contributor

@kieranj kieranj commented Apr 1, 2022

Ruby 2.6 was EOL as of 31/03/22 and ruby 3.0/3.1 have been widely adopted by the community so its important to run the test suite against these versions

kieranj and others added 4 commits April 1, 2022 11:15
Ruby 2.6 was EOL as of 31/03/22 and ruby 3.0/3.1 have been widely adopted by the community so its important to run the test suite against these versions
@gregjoy1
Copy link

Adding weight to this, Bookwhen upgraded to Ruby 3 recently and have found that the OpenActive dataset-site-template-ruby gem (that relies on this gem as a dependency) is broken.

Once this is resolved, we will upgrade to the latest version to resolve it. Unfortunately we are super busy at the moment and don't have the resources to investigate further.


ArgumentError: missing keyword: :field
  from openactive (0.1.2) lib/openactive/concerns/json_ld_serializable.rb:28:in `block in values'
  from openactive (0.1.2) lib/openactive/concerns/json_ld_serializable.rb:28:in `each'
  from openactive (0.1.2) lib/openactive/concerns/json_ld_serializable.rb:28:in `values'
  from openactive (0.1.2) lib/openactive/helpers/json_ld.rb:23:in `prepare_data_for_serialization'
  from openactive (0.1.2) lib/openactive/helpers/json_ld.rb:84:in `serialize_value'
  from openactive-dataset_site (0.1.1) lib/openactive/dataset_site/template_renderer.rb:29:in `method_missing'
  from mustache (1.1.1) lib/mustache/context.rb:148:in `call'
  from mustache (1.1.1) lib/mustache/context.rb:148:in `find'
  from mustache (1.1.1) lib/mustache/context.rb:116:in `block in fetch'
  from mustache (1.1.1) lib/mustache/context.rb:112:in `each'
  from mustache (1.1.1) lib/mustache/context.rb:112:in `fetch'
  from mustache (1.1.1) lib/mustache/context.rb:94:in `[]'
  from mustache (1.1.1) lib/mustache/template.rb:116:in `render'
  from mustache (1.1.1) lib/mustache/template.rb:44:in `render'
  from mustache (1.1.1) lib/mustache.rb:133:in `render'
  from app/classes/api/openactive/data_site/template_renderer.rb:9:in `render_data_site'
  ...

@nickevansuk nickevansuk changed the base branch from master to fix/ruby-3 June 17, 2024 15:34
@nickevansuk nickevansuk merged commit 31e05e1 into openactive:fix/ruby-3 Jun 17, 2024
0 of 3 checks passed
@nickevansuk
Copy link
Contributor

@gregjoy1 thanks for reporting this - I've just upgraded both to Ruby 3 (see openactive/dataset-site-template-ruby#22), so hopefully it'll be easy to get your dataset site up-and-runnning again!

@gregjoy1
Copy link

Hi @nickevansuk, massive thanks for this! 🙂 We have hit upon a snag where the activesupport dependency for this gem is pinned to version 6.1 and we are using version 7.1. Unfortunately this blocks the installation of the updated version of this gem as version 6.1 and 7.1 cannot co-exist within the same runtime.

FYI @kieranj

We are quite tight for time or else I would have forked it and resolved it myself. I know you are super busy but when you get a spare moment, please may you remove that pin so that we are able to use this with modern Rails 🙂

Also the latest version of the openactive-dataset_site Gem has not been pushed to Ruby gems yet (easy thing to miss), if its a quick job - may you push it or else we can explicitly specify the use of the Github repo with the latest commit. 🙂

@nickevansuk
Copy link
Contributor

Thanks @gregjoy1 - would this PR resolve this per your understanding? #46

openactive-dataset_site doesn't have a version of this library pinned, so it should just use the latest version? (the latest commit in that repo is just an update to CI).

I'm not a Rails developer, so do let me know if I'm misunderstanding anything here!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants