Address some more analyzer warnings #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -35,10 +35,10 @@ OpenAIErrorResponse errorResponse | |||
| public string ToExceptionMessage(int httpStatus) | |||
| { | |||
| StringBuilder messageBuilder = new(); | |||
| messageBuilder.AppendLine($"HTTP {httpStatus} ({Type}: {Code})"); | |||
| messageBuilder.Append("HTTP ").Append(httpStatus).Append(" (").Append(Type).Append(": ").Append(Code).AppendLine(")"); | |||
There was a problem hiding this comment.
what's the reason for this change?
There was a problem hiding this comment.
On netstandard2.0 it's allocating a new string only to then append that string.
On .NET Core it'll use the more efficient overload to avoid that, but an analyzer points out it should ideally be passing in a culture, and I can't do that without an ifdef.
If you're ok with an ifdef, I could do that and accept the lesser perf on netstandard (after all, this appears to only be exceptional). Or I could undo and if/when we enable that analyzer permanently we could suppress it here.
trrwilson
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.