-
Notifications
You must be signed in to change notification settings - Fork 279
Custom Realtime Model Selection #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
An excellent and most valuable feature -- Recognition and support to Anas for this work! |
@khorwood-openai or @jhills20 - would you mind taking a look at this? |
+1 |
if (!model) { | ||
this.realtimeModel = 'gpt-4o-realtime-preview-2024-10-01'; | ||
} else { | ||
this.realtimeModel = model; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if I'm not wrong, it can be done like this? this.realtimeModel = model || 'gpt-4o-realtime-preview-2024-10-01';
I’ve been testing your PR #92, which adds support for passing a custom model name via updateSession(), but I’m running into an issue where OpenAI still defaults to gpt-4o-realtime-preview-2024-10-01, even when explicitly setting gpt-4o-mini-realtime-preview-2024-12-17. 🔍 Findings So Far: 1️⃣ Model Name Appears in realtimeModel But Not in Active Session 2️⃣ Explicitly Calling updateSession({ model: "gpt-4o-mini-realtime-preview-2024-12-17" }) Still Doesn’t Work 3️⃣ Potential Issue with WebSocket Model Application 🚀 Next Steps Can you confirm if: Any guidance would be appreciated! Thanks for your work on this PR—it’s a much-needed feature, and I’d love to help get it fully functional. |
did this actually work for people? is model selection actually functional? I hardcoded the 4o mini model here - if (!model) { |
@AnasMations lol we're about 20 people to have fixed this issue and none of the PRs were accepted 😅. Surely one must be to OpenAI's taste at least... Eventhough it was a 5 minutes fix tops many of us should probably have looked at the open PR's before making a new, functionally identical one ahah. @devpras22 the official library no, it's still not gonna work. But pick any of the forks which 1) mention in the title that they fix this issue and 2) are not behind the
|
This PR introduces the ability to select a custom OpenAI realtime model in the
RealtimeClient
. Users can now specify the desired model for more flexibility and tailored API usage.Changes:
RealtimeClient
through theupdateSession
functionLet me know if there are any further changes or enhancements needed!