Create DataChannel by default #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seaduboi-openai
force-pushed
the
update-libpeer
branch
2 times, most recently
from
91790f1 to
16d6803
Compare
GOROman
reviewed
Jan 4, 2025
src/webrtc.cpp
Outdated
|
|
||
| static void oai_ondatachannel_onopen_task(void *userdata) { | ||
| if (peer_connection_create_datachannel(peer_connection, DATA_CHANNEL_RELIABLE, | ||
| 0, 0, (char *)"", (char *)"") != -1) { |
There was a problem hiding this comment.
I would suggest that the label name be set to oai-events to match the official documentation.
https://platform.openai.com/docs/guides/realtime-webrtc#sending-and-receiving-events
There was a problem hiding this comment.
@GOROman Fixed! Thank you so much for reviewing :)
seaduboi-openai
force-pushed
the
update-libpeer
branch
2 times, most recently
from
2fabe47 to
88da36d
Compare
GOROman
approved these changes
Jan 5, 2025
|
Thank you @GOROman When @sepfy merges sepfy/libpeer#180 I will update the submodule and merge this. If you have any other ideas/feedback/improvements I would love to work on them! I will spend tomorrow going through other issues. |
seaduboi-openai
force-pushed
the
update-libpeer
branch
from
88da36d to
98d1219
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.