Add "chart map" family #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add argument to control facet rows
Preferable to just cairo png.
Replace map_dfr w/ map > list_rbind, and map_chr w/ map_vec.
Merge Static Maps Branch
Add seealso to refer back to static maps.
Use categorical legend instead of steps, which has broadly fewer issues (e.g., no problems looking squished with lots of bins).
Use single icons rather than icon sets - more robust and less open to issues, and more similar to static maps.
Combine static/leaflet together now that they are so similar. May be able to reduce repetition further.
More robust, consistent w/ all-in-one maps
For whatever reason, some people may want non-circular markers. This allows a vector to be passed to d.icon and d.fig.
Fixes GR10/GR2.5 and hydrocarbons appearing in the legend
avoids partial arg matching
implement `control` fix
issues w/ encoding of file paths
Allow pairwise statistics in `polarMap()`
jack-davison
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tracks the implementation of #70.
Current ideas:
valueMap()- creates spot concentrations w/ one pollutant, or bar charts w/ multiple pollutantsdistributionMap()(a bit wordy) - creates histograms, density plots, (box plots?)trendMap()- creates trend plots (with bars, lines, steps, etc.)variationMap()- createstimeVariation()-style markers withtypeon the x-axisAlternatively, for simplicity for the user, can look for a single function,
chartMap(), that intelligently picks a default chart type depending on choice oftypeandpollutant, e.g.,