Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for Wordpress Annatator plugin to support new authorization API #13

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

denisoby
Copy link

@denisoby denisoby commented Nov 9, 2015

No description provided.

@tilgovi
Copy link
Member

tilgovi commented Jan 7, 2016

I'm sorry I have been silent on this. It's hard for me to review as one chunk.

The core of the changes look great. Some situation with jQuery seems to need a resolution. And I feel like we should be managing vendor dependencies some more modern way, but I'm not a PHP person.

What do you think?

@denisoby
Copy link
Author

denisoby commented Jan 7, 2016

From my point of view - we should make release. And after that make further
improvements, according to users feedback.

So, first of all - let's release. )

On Thu, Jan 7, 2016 at 6:27 AM, Randall Leeds [email protected]
wrote:

I'm sorry I have been silent on this. It's hard for me to review as one
chunk.

The core of the changes look great. Some situation with jQuery seems to
need a resolution. And I feel like we should be managing vendor
dependencies some more modern way, but I'm not a PHP person.

What do you think?


Reply to this email directly or view it on GitHub
#13 (comment)
.

Всего наилучшего, Обыденных Денис
ICQ: 40-10-808 Skype: denis.obydennykh
http://avtomurmansk.ru/

@tilgovi
Copy link
Member

tilgovi commented Jan 7, 2016

I haven't even been able to verify that it works yet, but I'll try to do that.

@denisoby
Copy link
Author

Randall, that really takes to much. Please, take a look.

On Thu, Jan 7, 2016 at 7:02 PM, Randall Leeds [email protected]
wrote:

I haven't even been able to verify that it works yet, but I'll try to do
that.


Reply to this email directly or view it on GitHub
#13 (comment)
.

Всего наилучшего, Обыденных Денис
ICQ: 40-10-808 Skype: denis.obydennykh
http://avtomurmansk.ru/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants