Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zone location creation in case there is no tile child. #148

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fix zone location creation in case there is no tile child. #148

wants to merge 2 commits into from

Conversation

DivineThreepwood
Copy link
Member

📜 Description

Changes proposed in this pull request:

  • Implement test that reproduces the location zone issue.
  • Fix consistency handling by defining tile as default location type.

✅ Checklist:

  • Created tests which fail without the change (if possible)
  • Extended the documentation (if necessary)

@DivineThreepwood
Implement test that reproduces the location zone issue. Fix consisten…
f05bcbc 
…cy handling by defining tile as default location type.
@DivineThreepwood DivineThreepwood linked an issue Feb 23, 2025 that may be closed by this pull request
A zone is saved as a tile. #147
Open
@netlify Netlify
Copy link

netlify bot commented Feb 23, 2025 •
edited
Loading

✅ Deploy Preview for basecubeone canceled.

Name Link
🔨 Latest commit 7da6fa9
🔍 Latest deploy log https://app.netlify.com/sites/basecubeone/deploys/67bb9f8315ecb00008510419

@DivineThreepwood DivineThreepwood changed the title Implement test that reproduces the location zone issue. Fix consisten… Fix zone location creation in case there is no tile child. Feb 23, 2025
@DivineThreepwood DivineThreepwood self-assigned this Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pLeminoq pLeminoq Awaiting requested review from pLeminoq

@LukBelter LukBelter Awaiting requested review from LukBelter

At least 1 approving review is required to merge this pull request.

Assignees

@DivineThreepwood DivineThreepwood

Labels
ready to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A zone is saved as a tile.
1 participant
@DivineThreepwood