Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for update 20230613.php #171

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

Postkassi
Copy link

Had an issue that was affecting the database update for mysql, current code is specific to mariadb. Updated code should work for both mysql and mariadb.

OB Description

Please include a summary of the change and which issue is fixed. Please provide enough information so that others can review your pull request. Explain the details for making this change. What existing problem does the pull request solve?
Demonstrate the code is solid. Include the exact commands you ran and their CLI output, screenshots or videos. List any dependencies that are required for this change.

**IMPORTANT: Search previous suggestions before making a new one, as yours may be a duplicate. Do not create a Pull Request without creating an issue first.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
I was trying to set up a new OB Server and could not update past database version 20230418, spent the day trying to figure it out. Ended up being an issue with me running mysql instead of mariadb, so this proposed change solves that.

Testing Environments

OpenBroadcaster Component and Version

  • OBServer 5.3.3
  • OBPlayer
  • Module
  • Other

Browser Version?

  • Chrome
  • Edge\IE 130.0.2849.46
  • Firefox
  • Safari
  • Other

OS Version?

  • BSD
  • Debian
  • Raspberry OS
  • Ubuntu (Flavour) 24.04.1 LTS
  • Other

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code and corrected any misspellings
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings Not sure about this one, it works for mysql, might need assitance with testing for mariaDB
  • I have added tests that prove my fix is effective or that my feature works Not sure how i can add tests that prove this works
  • New and existing unit tests pass locally with my changes Not sure what this means.

Thanks for contributing!

Had an issue that was affecting the database update for mysql, current code is specific to mariadb. Updated code should work for both mysql and mariadb.
@brookgagnon brookgagnon merged commit a1194ab into openbroadcaster:5.3-develop Nov 9, 2024
2 checks passed
@brookgagnon
Copy link
Contributor

appreciated, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants