Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CADC-13894] Firefly Changes #126

Merged
merged 9 commits into from
Feb 18, 2025
Merged

[CADC-13894] Firefly Changes #126

merged 9 commits into from
Feb 18, 2025

Conversation

shinybrar
Copy link
Collaborator

@shinybrar shinybrar commented Feb 11, 2025 •
edited by jira bot
Loading

  • Fixes to CADC-SSO Library
  • Added more testing to check for malformed and missing urls
  • Added k8s manifest for keel-deployment
  • Removed code which has now been contributed upstream in ipac/firefly

Completes Story CADC-13894 with Tasks CADC-13886, CADC-13887 & CADC-13888

@shinybrar shinybrar changed the title feat(entrypoint): updated entrypoint logic Firefly Changes Feb 18, 2025
@shinybrar shinybrar changed the title Firefly Changes [CADC-13894] Firefly Changes Feb 18, 2025
@shinybrar shinybrar requested a review from at88mph February 18, 2025 18:49
at88mph
at88mph requested changes Feb 18, 2025
View reviewed changes
Copy link
Member

@at88mph at88mph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more item.

@shinybrar shinybrar requested a review from at88mph February 18, 2025 22:04
@at88mph at88mph merged commit 50b8e4a into opencadc:main Feb 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@at88mph at88mph at88mph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shinybrar @at88mph