Activate eslint prefer-const

eslint.config.js

@@ -21,7 +21,6 @@ export default [
             "no-tabs": "off",
             "no-unused-expressions": "off",
             "object-curly-spacing": "off",
-            "prefer-const": "off",
             "quotes": "off",
             "semi": "off",
             "spaced-comment": "off",

src/components/configuration/Themes.tsx

@@ -51,7 +51,7 @@ const Themes = () => {
 		loadThemes();
 
 		// Fetch themes every minute
-		let fetchThemesInterval = setInterval(loadThemes, 5000);
+		const fetchThemesInterval = setInterval(loadThemes, 5000);
 
 		return () => {
 			allowLoadIntoTable = false;

src/components/events/Events.tsx

@@ -61,7 +61,7 @@ const Events = () => {
 	const events = useAppSelector(state => getTotalEvents(state));
 	const isFetchingAssetUploadOptions = useAppSelector(state => getIsFetchingAssetUploadOptions(state));
 
-	let location = useLocation();
+	const location = useLocation();
 
 	useEffect(() => {
 		// State variable for interrupting the load function
@@ -92,7 +92,7 @@ const Events = () => {
 		loadEvents();
 
 		// Fetch events every five seconds
-		let fetchEventsInterval = setInterval(() => loadEvents(), 5000);
+		const fetchEventsInterval = setInterval(() => loadEvents(), 5000);
 
 		return () => {
 			allowLoadIntoTable = false;

src/components/events/Series.tsx

@@ -39,7 +39,7 @@ const Series = () => {
 	const newSeriesModalRef = useRef<ModalHandle>(null);
 	const deleteModalRef = useRef<ModalHandle>(null);
 
-	let location = useLocation();
+	const location = useLocation();
 
 	const series = useAppSelector(state => getTotalSeries(state));
 	const showActions = useAppSelector(state => isShowActions(state));
@@ -72,7 +72,7 @@ const Series = () => {
 		loadSeries();
 
 		// Fetch series every minute
-		let fetchSeriesInterval = setInterval(() => loadSeries(), 5000);
+		const fetchSeriesInterval = setInterval(() => loadSeries(), 5000);
 
 		return () => {
 			allowLoadIntoTable = false;

src/components/events/partials/EventsDateCell.tsx

@@ -24,13 +24,13 @@ const EventsDateCell = ({
 
 	// Filter with value of current cell
 	const addFilter = async (date: string) => {
-		let filter = filterMap.find(({ name }) => name === "startDate");
+		const filter = filterMap.find(({ name }) => name === "startDate");
 		if (!!filter) {
-			let startDate = new Date(date);
+			const startDate = new Date(date);
 			startDate.setHours(0);
 			startDate.setMinutes(0);
 			startDate.setSeconds(0);
-			let endDate = new Date(date);
+			const endDate = new Date(date);
 			endDate.setHours(23);
 			endDate.setMinutes(59);
 			endDate.setSeconds(59);

src/components/events/partials/EventsLocationCell.tsx

@@ -21,7 +21,7 @@ const EventsLocationCell = ({
 
 	// Filter with value of current cell
 	const addFilter = (location: string) => {
-		let filter = filterMap.find(({ name }) => name === "location");
+		const filter = filterMap.find(({ name }) => name === "location");
 		if (!!filter) {
 			dispatch(editFilterValue({filterName: filter.name, value: location}));
 			dispatch(fetchEvents());

src/components/events/partials/EventsPresentersCell.tsx

@@ -21,7 +21,7 @@ const EventsPresentersCell = ({
 
 	// Filter with value of current cell
 	const addFilter = async (presenter: string) => {
-		let filter = filterMap.find(
+		const filter = filterMap.find(
 			({ name }) => name === "presentersBibliographic"
 		);
 		if (!!filter) {

src/components/events/partials/EventsSeriesCell.tsx

@@ -21,7 +21,7 @@ const EventsSeriesCell = ({
 
 	// Filter with value of current cell
 	const addFilter = async (seriesId: string) => {
-		let filter = filterMap.find(({ name }) => name === "series");
+		const filter = filterMap.find(({ name }) => name === "series");
 		if (!!filter) {
 			await dispatch(editFilterValue({filterName: filter.name, value: seriesId}));
 			await dispatch(fetchEvents());

src/components/events/partials/EventsTechnicalDateCell.tsx

@@ -24,7 +24,7 @@ const EventsTechnicalDateCell = ({
 
 	// Filter with value of current cell
 	const addFilter = async (date: string) => {
-		let filter = filterMap.find(({ name }) => name === "technicalStart");
+		const filter = filterMap.find(({ name }) => name === "technicalStart");
 		if (!!filter) {
 			await dispatch(editFilterValue({filterName: filter.name, value: date + "/" + date}));
 			await dispatch(fetchEvents());

src/components/events/partials/ModalTabsAndPages/DetailsMetadataTab.tsx

@@ -56,7 +56,7 @@ const DetailsMetadataTab = ({
 
 	// set current values of metadata fields as initial values
 	const getInitialValues = (metadataCatalog: MetadataCatalog) => {
-		let initialValues: { [key: string]: any } = {};
+		const initialValues: { [key: string]: any } = {};
 
 		// Transform metadata fields and their values provided by backend (saved in redux)
 		if (!!metadataCatalog.fields && metadataCatalog.fields.length > 0) {

src/components/events/partials/ModalTabsAndPages/EditScheduledEventsSummaryPage.tsx

@@ -48,11 +48,11 @@ const EditScheduledEventsSummaryPage = <T extends RequiredFormProps>({
 	}, []);
 
 	const checkForChanges = () => {
-		let changed: Change[] = [];
+		const changed: Change[] = [];
 
 		// Loop through each event selected for editing and compare original values and changed values
 		for (const event of formik.values.editedEvents) {
-			let eventChanges: Change = {
+			const eventChanges: Change = {
 				eventId: event.eventId,
 				title: event.title,
 				changes: [],

src/components/events/partials/ModalTabsAndPages/EventDetailsWorkflowOperations.tsx

@@ -39,7 +39,7 @@ const EventDetailsWorkflowOperations = ({
 		loadWorkflowOperations().then();
 
 		// Fetch workflow operations every 5 seconds
-		let fetchWorkflowOperationsInterval = setInterval(loadWorkflowOperations, 5000);
+		const fetchWorkflowOperationsInterval = setInterval(loadWorkflowOperations, 5000);
 
 		// Unmount interval
 		return () => clearInterval(fetchWorkflowOperationsInterval);

src/components/events/partials/ModalTabsAndPages/EventDetailsWorkflowTab.tsx

@@ -78,7 +78,7 @@ const EventDetailsWorkflowTab = ({
 	}, []);
 
 	const isCurrentWorkflow = (workflowId: string) => {
-		let currentWorkflow = workflows.entries[workflows.entries.length - 1];
+		const currentWorkflow = workflows.entries[workflows.entries.length - 1];
 		return currentWorkflow.id === workflowId;
 	};
 

src/components/events/partials/ModalTabsAndPages/NewProcessingPage.tsx

@@ -57,9 +57,9 @@ const NewProcessingPage = <T extends RequiredFormProps>({
 	};
 
 	const setDefaultValues = (value: string) => {
-		let workflowId = value;
+		const workflowId = value;
 		// fill values with default configuration of chosen workflow
-		let defaultConfiguration = setDefaultConfig(workflowDef, workflowId);
+		const defaultConfiguration = setDefaultConfig(workflowDef, workflowId);
 
 		// set default configuration in formik
 		formik.setFieldValue("configuration", defaultConfiguration);

src/components/events/partials/ModalTabsAndPages/NewSourcePage.tsx

@@ -368,7 +368,7 @@ const Schedule = <T extends {
 
 	const renderInputDeviceOptions = () => {
 		if (!!formik.values.location) {
-			let inputDevice = inputDevices.find(
+			const inputDevice = inputDevices.find(
 				({ name }) => name === formik.values.location
 			);
 			if (!inputDevice) {

src/components/events/partials/ModalTabsAndPages/StartTaskWorkflowPage.tsx

@@ -49,9 +49,9 @@ const StartTaskWorkflowPage = <T extends RequiredFormProps>({
 	}, [workflowDef]);
 
 	const setDefaultValues = (value: string) => {
-		let workflowId = value;
+		const workflowId = value;
 		// fill values with default configuration of chosen workflow
-		let defaultConfiguration = setDefaultConfig(workflowDef, workflowId);
+		const defaultConfiguration = setDefaultConfig(workflowDef, workflowId);
 
 		// set default configuration in formik
 		formik.setFieldValue("configuration", defaultConfiguration);

src/components/events/partials/modals/DeleteEventsModal.tsx

@@ -34,7 +34,7 @@ const DeleteEventsModal = ({
 	const onChangeAllSelected = (e: React.ChangeEvent<HTMLInputElement>) => {
 		const selected = e.target.checked;
 		setAllChecked(selected);
-		let changedSelection = selectedEvents.map((event) => {
+		const changedSelection = selectedEvents.map((event) => {
 			return {
 				...event,
 				selected: selected,
@@ -46,7 +46,7 @@ const DeleteEventsModal = ({
 	// Handle change of checkboxes indicating which events to consider further
 	const onChangeSelected = (e: React.ChangeEvent<HTMLInputElement>, id: string) => {
 		const selected = e.target.checked;
-		let changedEvents = selectedEvents.map((event) => {
+		const changedEvents = selectedEvents.map((event) => {
 			if (isEvent(event) && event.id === id) {
 				return {
 					...event,

src/components/events/partials/modals/DeleteSeriesModal.tsx

@@ -45,11 +45,11 @@ const DeleteSeriesModal = ({
 	useEffect(() => {
 		async function fetchData() {
 			// Query from backend if deletion of series with events allowed
-			let response = await getSeriesConfig();
+			const response = await getSeriesConfig();
 			setDeleteWithSeriesAllowed(response);
 
 			// Check for each selected series if it has events
-			let series = [];
+			const series = [];
 			for (let i = 0; i < selectedSeries.length; i++) {
 				const selectedSeriesInThisLoop = selectedSeries[i];
 				const events = isSeries(selectedSeriesInThisLoop) ? await hasEvents(selectedSeriesInThisLoop.id.toString()) : false;
@@ -74,7 +74,7 @@ const DeleteSeriesModal = ({
 	const onChangeAllSelected = (e: React.ChangeEvent<HTMLInputElement>) => {
 		const selected = e.target.checked;
 		setAllChecked(selected);
-		let changedSelection = selectedSeries.map((series) => {
+		const changedSelection = selectedSeries.map((series) => {
 			return {
 				...series,
 				selected: selected,
@@ -86,7 +86,7 @@ const DeleteSeriesModal = ({
 	// Handle change of checkboxes indicating which series to consider further
 	const onChangeSelected = (e: React.ChangeEvent<HTMLInputElement>, id: string) => {
 		const selected = e.target.checked;
-		let changedSeries = selectedSeries.map((series) => {
+		const changedSeries = selectedSeries.map((series) => {
 			if (isSeries(series) && series.id === id) {
 				return {
 					...series,

src/components/events/partials/modals/EditMetadataEventsModal.tsx

@@ -55,7 +55,7 @@ const EditMetadataEventsModal = ({
 		async function fetchData() {
 			setLoading(true);
 
-			let eventIds: string[] = [];
+			const eventIds: string[] = [];
 			selectedEvents.forEach((event) => isEvent(event) && eventIds.push(event.id));
 
 			// Get merged metadata from backend
@@ -64,7 +64,7 @@ const EditMetadataEventsModal = ({
 			.then(unwrapResult)
 			.then((result) => {
 				// Set initial values and save metadata field infos in state
-				let initialValues = getInitialValues(result.mergedMetadata);
+				const initialValues = getInitialValues(result.mergedMetadata);
 				setFetchedValues(initialValues);
 				setMetadataFields({
 					merged: result.merged,
@@ -90,8 +90,8 @@ const EditMetadataEventsModal = ({
 	};
 
 	const onChangeSelected = (e: React.ChangeEvent<HTMLInputElement>, fieldId: string) => {
-		let selected = e.target.checked;
-		let fields = metadataFields;
+		const selected = e.target.checked;
+		const fields = metadataFields;
 		fields.mergedMetadata = metadataFields.mergedMetadata.map((field) => {
 			if (field.id === fieldId) {
 				return {
@@ -112,16 +112,16 @@ const EditMetadataEventsModal = ({
 			return true;
 		}
 
-		let fetched = fetchedValues[field.id];
-		let inForm = formikValues[field.id];
+		const fetched = fetchedValues[field.id];
+		const inForm = formikValues[field.id];
 		let same = false;
 		if (fetched === inForm) {
 			same = true;
 		} else if (Array.isArray(fetched) && Array.isArray(inForm)) {
 			same = fetched.length === inForm.length && fetched.every((e, i) => e === inForm[i]);
 		}
 		if (!same) {
-			let fields = metadataFields;
+			const fields = metadataFields;
 			fields.mergedMetadata = metadataFields.mergedMetadata.map((f) => {
 				if (f.id === field.id) {
 					return {
@@ -299,7 +299,7 @@ const EditMetadataEventsModal = ({
 
 const getInitialValues = (metadataFields: MetadataFieldSelected[]) => {
 	// Transform metadata fields provided by backend (saved in redux)
-	let initialValues: { [key: string]: string | string[] } = {};
+	const initialValues: { [key: string]: string | string[] } = {};
 	metadataFields.forEach((field) => {
 		initialValues[field.id] = field.value;
 	});

src/components/events/partials/modals/EmbeddingCodeModal.tsx

@@ -23,15 +23,15 @@ const EmbeddingCodeModal = ({
 	useEffect(() => {
 		const fetchData = async () => {
 			// get source url
-			let sourceURL = await getSourceURL();
+			const sourceURL = await getSourceURL();
 
 			setSourceURL(sourceURL);
 		};
 		fetchData();
 	}, []);
 
 	const copy = () => {
-		let copyText = document.getElementById("social_embed-textarea") as HTMLTextAreaElement;
+		const copyText = document.getElementById("social_embed-textarea") as HTMLTextAreaElement;
 		if (copyText) {
 			copyText.select();
 			document.execCommand("copy");
@@ -42,14 +42,14 @@ const EmbeddingCodeModal = ({
 
 	const updateTextArea = (e: React.MouseEvent<HTMLButtonElement, MouseEvent>) => {
 		// chosen frame size
-		let frameSize = e.currentTarget.textContent;
+		const frameSize = e.currentTarget.textContent;
 
 		if (!frameSize) {
 			return;
 		}
 
 		// buttons containing possible frame sizes
-		let embedSizeButtons = document.getElementsByClassName("embedSizeButton");
+		const embedSizeButtons = document.getElementsByClassName("embedSizeButton");
 
 		// iterate through embedSizeButtons and mark the chosen size
 		if (frameSize) {
@@ -62,12 +62,12 @@ const EmbeddingCodeModal = ({
 			}
 		}
 		// split frameSize to be used in iFrameString
-		let size = frameSize.split("x");
+		const size = frameSize.split("x");
 
 		// build whole url
-		let url = sourceURL + "/play/" + eventId;
+		const url = sourceURL + "/play/" + eventId;
 		// code displayed in text area containing the iFrame to copy
-		let iFrameString = `<iframe allowfullscreen src="${url}"
+		const iFrameString = `<iframe allowfullscreen src="${url}"
 			style="border: 0; margin 0;" name="Player" scrolling="no"
 			width="${size[0]}" height="${size[1]}"></iframe>`
 			.replace(/\s\s+/g, ' ');

src/components/events/partials/wizards/NewEventSummary.tsx

@@ -67,13 +67,13 @@ const NewEventSummary = <T extends RequiredFormProps>({
 
 	// upload asset that user has provided
 	useEffect(() => {
-		let uploadAssetsNonTrack: {
+		const uploadAssetsNonTrack: {
 			name: string,
 			translate?: string,
 			value: any,
 		}[] = [];
 		for (let i = 0; uploadAssetOptions.length > i; i++) {
-			let fieldValue = formik.values[uploadAssetOptions[i].id];
+			const fieldValue = formik.values[uploadAssetOptions[i].id];
 			if (!!fieldValue) {
 				const displayOverride = uploadAssetOptions[i].displayOverride as ParseKeys
 				setUploadAssetsNonTrack(uploadAssetsNonTrack.concat({

src/components/events/partials/wizards/NewEventWizard.tsx

@@ -129,7 +129,7 @@ const NewEventWizard = ({
 		setSnapshot(values);
 
 		// set page as completely filled out
-		let updatedPageCompleted = pageCompleted;
+		const updatedPageCompleted = pageCompleted;
 		updatedPageCompleted[page] = true;
 		setPageCompleted(updatedPageCompleted);
 

src/components/events/partials/wizards/NewSeriesWizard.tsx

@@ -120,7 +120,7 @@ const NewSeriesWizard = ({
 		setSnapshot(values);
 
 		// set page as completely filled out
-		let updatedPageCompleted = pageCompleted;
+		const updatedPageCompleted = pageCompleted;
 		updatedPageCompleted[page] = true;
 		setPageCompleted(updatedPageCompleted);
 

src/components/shared/DropDown.tsx

@@ -113,7 +113,7 @@ const DropDown = <T, >({
 	};
 
 
-  let commonProps: Props = {
+  const commonProps: Props = {
 		tabIndex: tabIndex,
 		theme: (theme) => (dropDownSpacingTheme(theme)),
 		styles: style,

src/components/shared/MainNav.tsx

@@ -24,7 +24,7 @@ const MainNav = ({
 	toggleMenu: () => void,
 }) => {
 	const { t } = useTranslation();
-	let navigate = useNavigate();
+	const navigate = useNavigate();
 
 	const orgProperties = useAppSelector(state => getOrgProperties(state));
 

src/components/shared/RegistrationModal.tsx

@@ -85,7 +85,7 @@ const RegistrationModalContent = () => {
 	};
 
 	const fetchRegistrationInfos = async () => {
-		let registrationInfo = await fetchAdopterRegistration();
+		const registrationInfo = await fetchAdopterRegistration();
 
 		// merge response into initial values for formik
 		setInitialValues({...initialValues, ...registrationInfo});