Skip to content

Commit

Permalink
Merge pull request #2385 from opencb/TASK-5475-release
Browse files Browse the repository at this point in the history
TASK-5475 - The version of Java (11.0.21) used to run our analysis is deprecated, and SonarCloud no longer supports it.
  • Loading branch information
juanfeSanahuja authored Jan 26, 2024
2 parents 0b8ca91 + ccebb07 commit 86026da
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 12 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/scripts/get_same_branch.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ if [[ -z $BRANCH_NAME ]]; then
exit 1
fi

if [[ $BRANCH_NAME != "TASK-"* ]]; then
echo "No need to check dependencies."
exit 0
fi

function install(){
local REPO=$1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
java-version: '17'
cache: 'maven'
- name: Install dependencies branches
run: |
Expand Down
1 change: 0 additions & 1 deletion opencga-server/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,6 @@
<plugins>
<plugin>
<artifactId>maven-war-plugin</artifactId>
<version>2.6</version>
<configuration>
<warName>${opencga.war.name}</warName>
<!--
Expand Down
20 changes: 14 additions & 6 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -146,12 +146,8 @@
<servlet-api.version>2.5-20081211</servlet-api.version>

<kryo.version>2.23.0</kryo.version>
<!--TO REMOVE:
The version of Java (11.0.21) used to run this analysis is deprecated, and SonarCloud no longer supports it. Please upgrade to Java 17 or later.
As a temporary measure, you can set the property 'sonar.scanner.force-deprecated-java-version' to 'true' to continue using Java 11.0.21
This workaround will only be effective until January 28, 2024. After this date, all scans using the deprecated Java 11 will fail.
-->
<sonar.scanner.force-deprecated-java-version>true</sonar.scanner.force-deprecated-java-version>
<lombok.version>1.18.30</lombok.version>
<maven-war-plugin.version>3.4.0</maven-war-plugin.version>
</properties>

<scm>
Expand Down Expand Up @@ -993,6 +989,12 @@
<artifactId>grep4j</artifactId>
<version>${grep4j.version}</version>
</dependency>
<dependency>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
<version>${lombok.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.redisson</groupId>
<artifactId>redisson</artifactId>
Expand Down Expand Up @@ -1093,6 +1095,7 @@
<artifactId>kryo</artifactId>
<version>${kryo.version}</version>
</dependency>

</dependencies>
</dependencyManagement>

Expand All @@ -1117,6 +1120,11 @@
<artifactId>maven-surefire-report-plugin</artifactId>
<version>${maven-surefire-plugin.version}</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-war-plugin</artifactId>
<version>${maven-war-plugin.version}</version>
</plugin>
</plugins>
</pluginManagement>

Expand Down

0 comments on commit 86026da

Please sign in to comment.