Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK-4144 Fix structural variation (SV) catalogue counting in signature analysis #2310

Merged
merged 6 commits into from
Jul 5, 2023

Conversation

jtarraga
Copy link
Member

@jtarraga jtarraga commented Jul 3, 2023

Fix structural variation (SV) catalogue counting in signature analysis

@jtarraga
Copy link
Member Author

jtarraga commented Jul 3, 2023

@jtarraga jtarraga requested a review from j-coll July 3, 2023 15:28
@jtarraga jtarraga changed the title TASK-4144 TASK-4144 Fix structural variation (SV) catalogue counting in signature analysis Jul 3, 2023
// Write catalogue file from the genome context counts
PrintWriter pw = new PrintWriter(getOutDir().resolve(CATALOGUES_FILENAME_DEFAULT).toFile());
// Write catalogue file from the genome context counts
try (PrintWriter pw = new PrintWriter(getOutDir().resolve(CATALOGUES_FILENAME_DEFAULT).toFile())) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice try-with-resources! 🚀

@jtarraga jtarraga requested a review from j-coll July 4, 2023 07:28
@jtarraga jtarraga merged commit 00839ef into release-2.8.2.x Jul 5, 2023
25 of 26 checks passed
@jtarraga jtarraga deleted the TASK-4144 branch July 5, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants