Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK-5888 - REST Error : 414 URI too large and 431 Header too large #2443

Merged
merged 3 commits into from
May 17, 2024

Conversation

j-coll
Copy link
Member

@j-coll j-coll commented May 8, 2024

No description provided.

@j-coll j-coll requested a review from pfurio May 8, 2024 11:24
@halender
Copy link
Contributor

halender commented May 8, 2024

return this;
@Deprecated
protected void setLogFile(Object o) {
Configuration.reportUnusedField("configuration.yml#server.[rest|grpc].logFile", o);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this :)

@@ -200,6 +202,16 @@ private static void overwriteWithEnvironmentVariables(Configuration configuratio
}
}

public static void reportUnusedField(String field, Object value) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll definitely be using this method

@@ -34,68 +34,7 @@
public class ConfigurationTest {

@Test
public void test() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder who left this here...

@j-coll j-coll merged commit 9233577 into release-2.12.x May 17, 2024
5 of 6 checks passed
@j-coll j-coll deleted the TASK-5888 branch May 17, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants