Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK-6636 - Job Kill method in JavaScript client of OpenCGA sends the params as POST body data #2494

Merged
merged 1 commit into from
Aug 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pull-request-approved.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ jobs:
uses: ./.github/workflows/test-analysis.yml
needs: build
with:
test_profile: runShortTests,runMediumTests,runLongTests
test_profile: runShortTests,runMediumTests
secrets: inherit
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ def get_method_definition(self, category, endpoint):
f'"{self.get_endpoint_subcategory()}"' if self.subcategory else "null",
self.get_endpoint_id2() if self.get_endpoint_id2() else "null",
f'"{self.get_endpoint_action()}"' if self.get_endpoint_action() else "null",
"data" if self.has_body() else False,
"data" if self.has_body() else ("null" if self.get_endpoint_method(endpoint).lower() == "post" else False),
query_string_params
] if s)
return (f' {self.get_method_doc(endpoint)}'
Expand Down
4 changes: 2 additions & 2 deletions opencga-client/src/main/javascript/ClinicalAnalysis.js
Original file line number Diff line number Diff line change
Expand Up @@ -834,7 +834,7 @@ export default class ClinicalAnalysis extends OpenCGAParentClass {
* @returns {Promise} Promise object in the form of RestResponse instance.
*/
clearInterpretation(clinicalAnalysis, interpretations, params) {
return this._post("analysis/clinical", clinicalAnalysis, "interpretation", interpretations, "clear", params);
return this._post("analysis/clinical", clinicalAnalysis, "interpretation", interpretations, "clear", null, params);
}

/** Delete interpretation
Expand All @@ -859,7 +859,7 @@ export default class ClinicalAnalysis extends OpenCGAParentClass {
* @returns {Promise} Promise object in the form of RestResponse instance.
*/
revertInterpretation(clinicalAnalysis, interpretation, version, params) {
return this._post("analysis/clinical", clinicalAnalysis, "interpretation", interpretation, "revert", {version, ...params});
return this._post("analysis/clinical", clinicalAnalysis, "interpretation", interpretation, "revert", null, {version, ...params});
}

/** Update interpretation fields
Expand Down
2 changes: 1 addition & 1 deletion opencga-client/src/main/javascript/File.js
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ export default class File extends OpenCGAParentClass {
* @returns {Promise} Promise object in the form of RestResponse instance.
*/
upload(params) {
return this._post("files", null, null, null, "upload", params);
return this._post("files", null, null, null, "upload", null, params);
}

/** Return the acl defined for the file or folder. If member is provided, it will only return the acl for the member.
Expand Down
4 changes: 2 additions & 2 deletions opencga-client/src/main/javascript/GA4GH.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export default class GA4GH extends OpenCGAParentClass {
* @returns {Promise} Promise object in the form of RestResponse instance.
*/
searchReads() {
return this._post("ga4gh", null, "reads", null, "search");
return this._post("ga4gh", null, "reads", null, "search", null);
}

/** Fetch alignment files using HTSget protocol
Expand Down Expand Up @@ -78,7 +78,7 @@ export default class GA4GH extends OpenCGAParentClass {
* @returns {Promise} Promise object in the form of RestResponse instance.
*/
searchVariants() {
return this._post("ga4gh", null, "variants", null, "search");
return this._post("ga4gh", null, "variants", null, "search", null);
}

}
2 changes: 1 addition & 1 deletion opencga-client/src/main/javascript/Job.js
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ export default class Job extends OpenCGAParentClass {
* @returns {Promise} Promise object in the form of RestResponse instance.
*/
kill(job, params) {
return this._post("jobs", job, null, null, "kill", params);
return this._post("jobs", job, null, null, "kill", null, params);
}

/** Show the first lines of a log file (up to a limit)
Expand Down
2 changes: 1 addition & 1 deletion opencga-client/src/main/javascript/Project.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export default class Project extends OpenCGAParentClass {
* @returns {Promise} Promise object in the form of RestResponse instance.
*/
incRelease(project) {
return this._post("projects", project, null, null, "incRelease");
return this._post("projects", project, null, null, "incRelease", null);
}

/** Fetch all the studies contained in the project
Expand Down
2 changes: 1 addition & 1 deletion opencga-client/src/main/javascript/Study.js
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ export default class Study extends OpenCGAParentClass {
* @returns {Promise} Promise object in the form of RestResponse instance.
*/
uploadTemplates(study, params) {
return this._post("studies", study, "templates", null, "upload", params);
return this._post("studies", study, "templates", null, "upload", null, params);
}

/** Delete template
Expand Down
2 changes: 1 addition & 1 deletion opencga-client/src/main/javascript/User.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export default class User extends OpenCGAParentClass {
* @returns {Promise} Promise object in the form of RestResponse instance.
*/
anonymous(organization) {
return this._post("users", null, null, null, "anonymous", organization);
return this._post("users", null, null, null, "anonymous", null, organization);
}

/** Create a new user
Expand Down
Loading