This repository has been archived by the owner on Oct 14, 2024. It is now read-only.

Rename Target to Asset and ScanResult to AssetScan #282

Merged

1 commit merged into main from rename_targets

Jun 30, 2023

ghost commented Apr 26, 2023

Description

This aligns with the UX and also aligns better with the objects' purposes. This is a breaking change with no migration, VMClarity will need to be reinstalled after this change.

Type of Change

[ ] Bug Fix
[ ] New Feature
[X] Breaking Change
[X] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

I have read the contributing guidelines
Existing issues have been referenced (where applicable)
I have verified this change is not present in other open pull requests
Functionality is documented
All code style checks pass
New code contribution is covered by automated tests
All new and existing tests pass

ghost self-requested a review as a code owner

April 26, 2023 14:05

ghost force-pushed the rename_targets branch from 83f65fe to baed052 Compare

April 26, 2023 14:05

akpsgit reviewed

View reviewed changes

api/openapi.yaml Outdated Show resolved Hide resolved

akpsgit reviewed

View reviewed changes

api/openapi.yaml Outdated Show resolved Hide resolved

akpsgit reviewed

View reviewed changes

api/openapi.yaml Outdated Show resolved Hide resolved

akpsgit reviewed

View reviewed changes

backend/pkg/database/gorm/target.go Outdated Show resolved Hide resolved

akpsgit reviewed

View reviewed changes

backend/pkg/database/gorm/target.go Outdated Show resolved Hide resolved

akpsgit reviewed

View reviewed changes

backend/pkg/database/gorm/target.go Outdated Show resolved Hide resolved

akpsgit reviewed

View reviewed changes

runtime_scan/pkg/scanner/scanner.go Outdated Show resolved Hide resolved

akpsgit reviewed

View reviewed changes

runtime_scan/pkg/types/types.go Outdated Show resolved Hide resolved

akpsgit reviewed

View reviewed changes

backend/pkg/database/gorm/asset_scan.go Outdated Show resolved Hide resolved

akpsgit reviewed

View reviewed changes

backend/pkg/database/gorm/asset_scan.go Outdated Show resolved Hide resolved

akpsgit reviewed

View reviewed changes

runtime_scan/pkg/orchestrator/orchestrator.go Outdated Show resolved Hide resolved

akpsgit reviewed

View reviewed changes

runtime_scan/pkg/orchestrator/scanresultprocessor/common.go Outdated Show resolved Hide resolved

akpsgit reviewed

View reviewed changes

runtime_scan/pkg/orchestrator/scanresultprocessor/common.go Outdated Show resolved Hide resolved

akpsgit reviewed

View reviewed changes

backend/pkg/rest/target_controller.go Show resolved Hide resolved

akpsgit reviewed

View reviewed changes

runtime_scan/pkg/cloudinit/cloudinit_template.go Outdated Show resolved Hide resolved

akpsgit reviewed

View reviewed changes

cli/cmd/root.go Outdated Show resolved Hide resolved

akpsgit reviewed

View reviewed changes

cli/cmd/root.go Show resolved Hide resolved

akpsgit reviewed

View reviewed changes

cli/pkg/presenter/vmclarity.go Outdated Show resolved Hide resolved

akpsgit reviewed

View reviewed changes

shared/pkg/backendclient/client.go Outdated Show resolved Hide resolved

akpsgit reviewed

View reviewed changes

ui/src/layout/Findings/LinkesDisplay.js Outdated Show resolved Hide resolved

Contributor

akpsgit commented May 7, 2023

@sambetts-cisco There are many files that still have "scan result/s". Can you please look for those (i didn't leave a comment in all places.)

ghost marked this pull request as draft

May 17, 2023 14:44

ghost force-pushed the rename_targets branch 2 times, most recently from 19319ea to 0d0fdb2 Compare

June 16, 2023 14:41

ghost marked this pull request as ready for review

June 16, 2023 14:42

ghost force-pushed the rename_targets branch from 0d0fdb2 to cebe72f Compare

June 16, 2023 14:45

chrisgacsal added this to the v0.6.0 milestone

ghost force-pushed the rename_targets branch from cebe72f to 3309eb9 Compare

June 26, 2023 12:26

ghost force-pushed the rename_targets branch 4 times, most recently from 582ae01 to f454d36 Compare

June 30, 2023 09:35

ramizpolic reviewed

View reviewed changes

backend/pkg/database/gorm/asset.go Show resolved Hide resolved

ghost force-pushed the rename_targets branch from f454d36 to 0b05e34 Compare

June 30, 2023 10:05

ramizpolic reviewed

View reviewed changes

runtime_scan/pkg/orchestrator/assetscanprocessor/vulnerabilities.go Show resolved Hide resolved

ramizpolic reviewed

View reviewed changes

runtime_scan/pkg/orchestrator/config.go Outdated Show resolved Hide resolved

ramizpolic previously approved these changes

View reviewed changes

Member

ramizpolic left a comment

lgtm, good stuff! 🚀

ghost force-pushed the rename_targets branch from 0b05e34 to b66050b Compare

June 30, 2023 11:17


          Rename Target to Asset and ScanResult to AssetScan

2fa1871

This aligns with the UX and also aligns better with the objects'
purposes. This is a breaking change with no migration, VMClarity will
need to be reinstalled after this change.

ghost dismissed ramizpolic’s stale review via

2fa1871

June 30, 2023 11:28

ghost force-pushed the rename_targets branch from b66050b to 2fa1871 Compare

June 30, 2023 11:28

ramizpolic approved these changes

View reviewed changes

ghost added this pull request to the merge queue

Merged via the queue into main with commit e6c069f

ghost deleted the rename_targets branch

June 30, 2023 12:44

adamtagscherer mentioned this pull request

fix: rename asset to target in cloud init #1382

Merged

7 tasks

This pull request was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet