Skip to content
This repository has been archived by the owner on Oct 14, 2024. It is now read-only.

fix: Fix issues with postgres DB support #440

Merged
1 commit merged into from
Jul 4, 2023
Merged

fix: Fix issues with postgres DB support #440

1 commit merged into from
Jul 4, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jun 30, 2023

Description

  • Removes any timestamp casting from the indexes, these aren't allowed to be part of an expression index in postgres.

  • Ensures that null values are handled correctly by JSONB_EACH_ARRAY. The postgres function expect the data must be an array, so we need to detect any other types in the SQL statement and switch it to empty array.

Type of Change

[X] Bug Fix
[ ] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@ghost ghost self-requested a review as a code owner June 30, 2023 15:41
* Removes any timestamp casting from the indexes, these aren't allowed
  to be part of an expression index in postgres.

* Ensures that null values are handled correctly by JSONB_EACH_ARRAY.
  The postgres function expect the data must be an array, so we need to
  detect any other types in the SQL statement and switch it to empty
  array.
@ghost ghost enabled auto-merge July 4, 2023 07:11
@ghost ghost added this pull request to the merge queue Jul 4, 2023
Merged via the queue into main with commit 9b88720 Jul 4, 2023
@ghost ghost deleted the postgres_fix branch July 4, 2023 09:10
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants