feat: Remodel so that scan objects can be used separately #443

ghost · 2023-07-04T16:12:38Z

Description

This commit remodels ScanConfigs, Scans and AssetScans so that Scans and AssetScans can be created independently from each other. This opens the door for a number of different use cases some examples are:

creating a single Scan without a ScanConfig if you just want to scan once now.
creating an AssetScan for a specific asset without a Scan to scan a specific asset now.
creating an AssetScan with results for a asset without going through the orchestrator at all, for example when reporting results from a scan in CI/CD

Type of Change

[ ] Bug Fix
[X] New Feature
[X] Breaking Change
[X] Refactor
[ ] Documentation
[ ] Other (please describe)

Checklist

I have read the contributing guidelines
Existing issues have been referenced (where applicable)
I have verified this change is not present in other open pull requests
Functionality is documented
All code style checks pass
New code contribution is covered by automated tests
All new and existing tests pass

backend/pkg/database/gorm/database.go

pbalogh-sa

LGTM

backend/pkg/database/gorm/asset_scan.go

ui/src/layout/Findings/utils.js

ui/src/layout/Scans/ScanConfigWizardModal/index.js

ui/src/layout/Findings/Vulnerabilities/VulnerabilityDetails.js

This commit remodels ScanConfigs, Scans and AssetScans so that Scans and AssetScans can be created independently from each other. This opens the door for a number of different use cases some examples are: - creating a single Scan without a ScanConfig if you just want to scan once now. - creating an AssetScan for a specific asset without a Scan to scan a specific asset now. - creating an AssetScan with results for a asset without going through the orchestrator at all, for example when reporting results from a scan in CI/CD

ghost self-requested a review as a code owner July 4, 2023 16:12

ghost force-pushed the remodel_scans_new branch 2 times, most recently from 6a8b9cb to aef8080 Compare July 5, 2023 07:38

fishkerez reviewed Jul 6, 2023

View reviewed changes

backend/pkg/database/gorm/database.go Show resolved Hide resolved

pbalogh-sa reviewed Jul 13, 2023

View reviewed changes

ghost force-pushed the remodel_scans_new branch 2 times, most recently from bbab456 to 5dc17dc Compare July 14, 2023 11:59