-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(test): add end to end tests skeleton and some basic tests #539
Conversation
50ae4e0
to
70c4fca
Compare
7b613bb
to
5127cca
Compare
1894c78
to
d397a9a
Compare
904fbb4
to
e74a6c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Side note: will e2e run as a pipeline step?
@ramizpolic thank you so much for reviewing! The plan is to initially run the tests in the pipeline but to not gate any merging. Once we are happy with the test reliability, we can change this. |
698e4d7
to
6a4c19c
Compare
bbba833
to
9f1b3f4
Compare
a5c2be5
to
c13dbc1
Compare
c13dbc1
to
3def20f
Compare
c5ca772
to
2f47739
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested the E2E locally and it works like charm. Thanks a lot for the effort @paralta! This is huge!
Description
#333
Type of Change
[ ] Bug Fix
[x] New Feature
[ ] Breaking Change
[ ] Refactor
[ ] Documentation
[ ] Other (please describe)
Checklist