Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/dont save if nan #71

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Issue/dont save if nan #71

merged 3 commits into from
Sep 5, 2023

Conversation

peterdudfield
Copy link
Contributor

Pull Request

Description

Dont save GSP Yields if theya re nans

Helps with openclimatefix/uk-pv-forecast-blend#8

How Has This Been Tested?

CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #71 (b7892e1) into main (7ce59d6) will increase coverage by 0.02%.
Report is 41 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   95.56%   95.58%   +0.02%     
==========================================
  Files           5        5              
  Lines         203      204       +1     
==========================================
+ Hits          194      195       +1     
  Misses          9        9              
Files Changed Coverage Δ
gspconsumer/__init__.py 100.00% <100.00%> (ø)
gspconsumer/app.py 96.87% <100.00%> (+0.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@peterdudfield peterdudfield merged commit 8169936 into main Sep 5, 2023
1 check passed
@peterdudfield peterdudfield deleted the issue/dont-save-if-nan branch September 5, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant