Merge pull request #105 from openclimatefix/chris/validation-step-error

Fixed error caused by incorrect call to common_metrics in validation step
openclimatefix · Dec 21, 2023 · 195841f · 195841f
2 parents f078879 + b341182
commit 195841f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pvnet/models/base_model.py b/pvnet/models/base_model.py
@@ -370,7 +370,7 @@ def _calculate_val_losses(self, y, y_hat):
             # Take median value for remaining metric calculations
             y_hat = self._quantiles_to_prediction(y_hat)
 
-        common_metrics_each_step = common_metrics(predictions=y_hat, target=y)
+        common_metrics_each_step = common_metrics(predictions=y_hat.numpy(), target=y.numpy())
         mse_each_step = common_metrics_each_step["rmse"] ** 2
         mae_each_step = common_metrics_each_step["mae"]
 

diff --git a/requirements.txt b/requirements.txt
@@ -1,5 +1,5 @@
 ocf_datapipes>=3.0.0
-ocf_ml_metrics
+ocf_ml_metrics>=0.0.11
 numpy
 pandas
 matplotlib