Skip to content

Commit

Permalink
Fixed error from calling common_metrics in validation step
Browse files Browse the repository at this point in the history
  • Loading branch information
confusedmatrix committed Dec 13, 2023
1 parent adeb778 commit 43b0285
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pvnet/models/base_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ def _calculate_val_losses(self, y, y_hat):
# Take median value for remaining metric calculations
y_hat = self._quantiles_to_prediction(y_hat)

common_metrics_each_step = common_metrics(predictions=y_hat, targets=y)
common_metrics_each_step = common_metrics(predictions=y_hat.numpy(), target=y.numpy())

Check warning on line 373 in pvnet/models/base_model.py

View check run for this annotation

Codecov / codecov/patch

pvnet/models/base_model.py#L373

Added line #L373 was not covered by tests
mse_each_step = common_metrics_each_step["rmse"] ** 2
mae_each_step = common_metrics_each_step["mae"]

Expand Down

0 comments on commit 43b0285

Please sign in to comment.