Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix batch to tensor and to device for nested NWP #112

Merged
merged 4 commits into from
Dec 21, 2023
Merged

Conversation

dfulu
Copy link
Member

@dfulu dfulu commented Dec 21, 2023

The copy_batch_to_device and batch_to_tensor need to be updated for the nested NWP data in the NumpyBatch of datapipes>=2.5

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (ffbfa04) 57.67% compared to head (de08431) 57.65%.
Report is 1 commits behind head on main.

Files Patch % Lines
pvnet/data/utils.py 45.45% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
- Coverage   57.67%   57.65%   -0.02%     
==========================================
  Files          26       26              
  Lines        1701     1705       +4     
==========================================
+ Hits          981      983       +2     
- Misses        720      722       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dfulu dfulu requested a review from jacobbieker December 21, 2023 16:28
@dfulu dfulu marked this pull request as ready for review December 21, 2023 16:29
@dfulu dfulu merged commit 48be53b into main Dec 21, 2023
2 of 4 checks passed
@dfulu dfulu deleted the batch_transfer_update branch December 21, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants