Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add end-to-end training test #113

Merged
merged 4 commits into from
Dec 21, 2023
Merged

Add end-to-end training test #113

merged 4 commits into from
Dec 21, 2023

Conversation

dfulu
Copy link
Member

@dfulu dfulu commented Dec 21, 2023

Pull Request

Description

Add a test to test training the model using pytorch lightning end-to-end. This adds test coverage to a wider range of the functions in the library. Particularly the pytorch lightning integration functions around computing metrics for training and validation.

Closes #109

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b341182) 50.85% compared to head (eed5241) 57.67%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
+ Coverage   50.85%   57.67%   +6.81%     
==========================================
  Files          26       26              
  Lines        1701     1701              
==========================================
+ Hits          865      981     +116     
+ Misses        836      720     -116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dfulu dfulu marked this pull request as ready for review December 21, 2023 16:03
@dfulu dfulu requested a review from peterdudfield December 21, 2023 16:03
@dfulu dfulu merged commit ffbfa04 into main Dec 21, 2023
4 checks passed
@dfulu dfulu deleted the end2end_test branch December 21, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full end2end training test
2 participants