Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a weather data page on the dashboard #259

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

ADIMANV
Copy link
Contributor

@ADIMANV ADIMANV commented Jan 17, 2025

Pull Request

Description

The following page adds a weather data page to dashboards to get historical or forecast temperature and wind speed data on the dashboard

image

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@ADIMANV ADIMANV requested a review from peterdudfield January 17, 2025 10:11
Copy link
Contributor

@peterdudfield peterdudfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great. Well done for getting this working. Ive left one comment.

I wonder also, if you could do multe select for the variables, so you can load a few variables at once, and display them

src/weather_graph.py Outdated Show resolved Hide resolved
@ADIMANV ADIMANV merged commit a1d3909 into main Jan 21, 2025
4 checks passed
@ADIMANV ADIMANV deleted the Weather-data-on-the-dashboard branch January 21, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants