Refactor data retrieval functions: get_all_users ,get_all_site_group #266
+12
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,7 +10,7 @@ | |||
| from pvsite_datamodel.read.model import get_models | |||
| from pvsite_datamodel.sqlmodels import SiteAssetType | |||
|
|
|||
| from get_data import get_all_users, get_all_site_groups | |||
| # from get_data import get_all_users, get_all_site_groups # Function has been already transferred to pvsite_datamodel.read.user | |||
There was a problem hiding this comment.
remove this fully, its ok, its in the git history
| get_all_users, | ||
| get_all_site_groups, | ||
| ) | ||
| # from get_data import ( |
There was a problem hiding this comment.
remove commented out code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Function : get_all_users in pv_site_datamodel
Function : get_all_site_groups in pv_site_datamodel
Fixes #89
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
Checklist: