Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename to sheffield_solar_passiv #82

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

peterdudfield
Copy link
Contributor

Pull Request

Description

rename 'solar_sheffield_passiv' to 'sheffield_solar_passiv'

Update:
PVConsumer (and deploy)
Nowcasting_dataset
Nowcasting_forecast (and deploy)

Update database 'pv_systems' table

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield self-assigned this Jun 29, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #82 (8e2202e) into main (9eda0c8) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   98.49%   98.49%           
=======================================
  Files          17       17           
  Lines         799      799           
=======================================
  Hits          787      787           
  Misses         12       12           
Impacted Files Coverage Δ
nowcasting_datamodel/models/pv.py 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants