Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add UKV #226

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

add UKV #226

wants to merge 19 commits into from

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Jan 21, 2025

Pull Request

Description

Add UKV MO model. This has x and y as main dims, with lat and lot as a grid.

  • this gets new results every hour
  • lat long seem to be still in the zarr (check TODO)

We might need to add #222 so that not data is not pulled twice

openclimatefix/ocf-infrastructure#697

How Has This Been Tested?

  • ran locally
  • added a test

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield changed the title Ukv add UKV Jan 21, 2025
@peterdudfield peterdudfield marked this pull request as draft January 21, 2025 19:14
@peterdudfield peterdudfield requested a review from devsjc January 21, 2025 19:15
@peterdudfield
Copy link
Contributor Author

This is my first try at this @devsjc, I wonder if you could have a look and advise

@devsjc
Copy link
Collaborator

devsjc commented Jan 22, 2025

A great first effort Peter! Hopefully it wasn't too much of a pain to figure out, I like to think the model API is fairly self-explanatory, but its certainly easy for me to say...!

@peterdudfield peterdudfield marked this pull request as ready for review January 22, 2025 12:51
@peterdudfield peterdudfield marked this pull request as draft January 22, 2025 14:05
@peterdudfield
Copy link
Contributor Author

peterdudfield commented Jan 30, 2025

I havent quite got this working yet. The trick thing is lat and lot are coordinates but not dims in the data array.

One option is to not save the lat/lon coordinates, but I think it would be good to do this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants