note TODO

openclimatefix · Aug 6, 2024 · 092147d · 092147d
1 parent 387c8d0
commit 092147d
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/ocf_data_sampler/select/find_contiguous_t0_time_periods.py b/ocf_data_sampler/select/find_contiguous_t0_time_periods.py
@@ -256,6 +256,12 @@ def intersection_of_2_dataframes_of_periods(a: pd.DataFrame, b: pd.DataFrame) ->
         # b:  |--|       |---|   |---|      |------|    |-|
         # In all five, `a` must always start before `b` ends,
         # and `a` must always end after `b` starts:
+
+        # TODO: <= and >= because we should allow overlap time periods of length 1. e.g.
+        # a: |----|      or   |---|   
+        # b:      |--|            |---|
+        # These aren't allowed if we use < and >.
+
         overlapping_periods = b[(a_period.start_dt < b.end_dt) & (a_period.end_dt > b.start_dt)]
 
         # There are two ways in which two periods may *not* overlap: