-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added spatial coarsening for input #115
Conversation
@Sukh-P, I think the file path being used for testing is incorrect.
|
You ok to merge in the latest main branch? This should get tests passing |
Yes , thank you ! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
==========================================
- Coverage 94.71% 92.34% -2.37%
==========================================
Files 39 40 +1
Lines 1060 1163 +103
==========================================
+ Hits 1004 1074 +70
- Misses 56 89 +33 ☔ View full report in Codecov by Sentry. |
@peterdudfield is this ready to merge or any other changes needed? |
Hey @alirashidAR I think this is missing a unit test, there is an example of a test here and you could use this test data which is constructed here, hope that is okay to add, thank you! Also this function I think would be better suited in this file as this is where it will actually be called and it won't be used anywhere else currently, it won't be called in any of the functions in the load folder |
ocf_data_sampler/load/utils.py
Outdated
@@ -1,5 +1,6 @@ | |||
import xarray as xr | |||
import pandas as pd | |||
import numpy as np |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this import can be removed now, not blocking merging in but would be nice to clean up before we do! Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for adding this in!
Thank you for the approval ! |
Pull Request
Description
Issue #92
Added the
coarsen_data
function inocf_data_sampler/load/utils.py
to coarsen the data to a specified resolution in degrees.Checklist: