Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: sun and datetimes dataloader issue #140

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Jan 22, 2025

Pull Request

Description

Fixing datetime bug

move sun and datetime features to coordinates, for some reason, torch.dataloader didnt load that dimension when it wasnt connected to any data.

openclimatefix/PVNet#304

How Has This Been Tested?

  • TDD, so added a test
  • then fixed it, and test passed

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield requested a review from Sukh-P January 22, 2025 16:17
@peterdudfield peterdudfield changed the title TDD: add test, currently failing Fix: sun and datetimes dataloader issue Jan 22, 2025
Copy link
Member

@Sukh-P Sukh-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work fixing this! Thank you

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.58%. Comparing base (930d9ed) to head (f2a0b50).
Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
- Coverage   92.69%   92.58%   -0.12%     
==========================================
  Files          39       40       +1     
  Lines        1123     1146      +23     
==========================================
+ Hits         1041     1061      +20     
- Misses         82       85       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterdudfield peterdudfield merged commit e751276 into main Jan 22, 2025
7 of 8 checks passed
@peterdudfield peterdudfield deleted the issue/datetime-bug branch January 22, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants