Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for dataset.pvnet #4

Merged
merged 4 commits into from
Aug 2, 2024
Merged

add test for dataset.pvnet #4

merged 4 commits into from
Aug 2, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Aug 2, 2024

Pull Request

Description

Add test for pvnet dataset
added test_data too

Fixes #

How Has This Been Tested?

CI tests + ran locally

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield requested a review from dfulu August 2, 2024 14:46
Copy link
Member

@dfulu dfulu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer if we can use create data on the fly in tests as much as possible. I think its easier to maintain, but this is grand for now

@peterdudfield
Copy link
Contributor Author

I'd prefer if we can use create data on the fly in tests as much as possible. I think its easier to maintain, but this is grand for now

Ill try and remake it now,

@peterdudfield peterdudfield merged commit 804aeb0 into development Aug 2, 2024
3 checks passed
@peterdudfield peterdudfield deleted the pvnet_test branch August 2, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants