Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select time test #5

Merged
merged 8 commits into from
Aug 7, 2024
Merged

Select time test #5

merged 8 commits into from
Aug 7, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Aug 2, 2024 •
edited
Loading

Pull Request

Description

add test for time select
Helps with #8

How Has This Been Tested?

CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield changed the base branch from main to development August 2, 2024 15:24
@peterdudfield peterdudfield requested a review from dfulu August 2, 2024 16:48
@peterdudfield peterdudfield mentioned this pull request Aug 2, 2024
Closed
11 tasks
@dfulu dfulu merged commit 981384f into development Aug 7, 2024
3 checks passed
@dfulu dfulu deleted the select_time_test branch August 7, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfulu dfulu dfulu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdudfield @dfulu