Config refactor #61
Open
Config refactor #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AUdaltsova
requested review from
dfulu and
peterdudfield
and removed request for
dfulu
|
this should be merged after #45 is merged |
# Conflicts: # ocf_data_sampler/config/__init__.py # ocf_data_sampler/config/load.py # ocf_data_sampler/config/model.py # ocf_data_sampler/config/save.py # ocf_data_sampler/torch_datasets/pvnet_uk_regional.py # requirements.txt # tests/config/test_config.py # tests/test_data/configs/test_config.yaml # tests/torch_datasets/test_pvnet_uk_regional.py
|
Interval start/end will need to be added but other than that ready for review |
peterdudfield
requested changes
Oct 31, 2024
Sukh-P
reviewed
Nov 1, 2024
|
Really nice work cleaning up the config data model! |
Sukh-P
approved these changes
Nov 1, 2024
Co-authored-by: Sukhil Patel <[email protected]>
AUdaltsova
commented
Nov 4, 2024
AUdaltsova
commented
Nov 4, 2024
peterdudfield
approved these changes
Nov 4, 2024
# Conflicts: # ocf_data_sampler/config/model.py # ocf_data_sampler/torch_datasets/pvnet_uk_regional.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Fixes #59
How Has This Been Tested?
ran the tests locally
Checklist: