Update networking module to output security group id

openclimatefix · Nov 10, 2023 · ffda7ae · ffda7ae
1 parent a58e778
commit ffda7ae
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/terraform/modules/networking/output.tf b/terraform/modules/networking/output.tf
@@ -18,6 +18,10 @@ output "private_subnet_group_name" {
   value = aws_db_subnet_group.private_subnet_group.name
 }
 
+output "default_security_group_id" {
+  value = aws_security_group.default.id
+}
+
 output "vpc_region" {
   value = var.region
 }
diff --git a/terraform/nowcasting/development/main.tf b/terraform/nowcasting/development/main.tf
@@ -424,5 +424,5 @@ module "airflow" {
   db_url        = module.database.forecast-database-secret-airflow-url
   docker-compose-version       = "0.0.3"
   ecs_subnet_id = module.networking.public_subnet_ids[0]
-  ecs_security_group=var.ecs_security_group # TODO should be able to update this to use the module
+  ecs_security_group=module.networking.default_security_group_id
 }
diff --git a/terraform/nowcasting/development/variables.tf b/terraform/nowcasting/development/variables.tf
@@ -89,8 +89,3 @@ variable "forecast_pvnet_version" {
 variable "forecast_blend_version" {
   description = "The Forecast Blend docker version"
 }
-
-variable "ecs_security_group" {
-  description = "The security group for airflow ecs tasks. TODO remove this"
-  type = string
-}