Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add s3 bucket, add to forecast, move foreacst ruvnl to ecs task #696

Merged
merged 4 commits into from
Nov 28, 2024
Merged

add s3 bucket, add to forecast, move foreacst ruvnl to ecs task #696

merged 4 commits into from
Nov 28, 2024

Conversation

peterdudfield
Copy link
Contributor

Pull Request

Description

  • change RUNVL forecast to ecs task
  • add s3 bucket for forecast
  • add s3 bucket SAV_BATCHES_DIR to both india forecasts

Fixes #

How Has This Been Tested?

CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield marked this pull request as ready for review November 26, 2024 16:50
@peterdudfield peterdudfield merged commit ae4ba63 into main Nov 28, 2024
5 checks passed
@peterdudfield peterdudfield deleted the add-s3-bucket-india-forecast branch November 28, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsjc devsjc devsjc approved these changes

@Sukh-P Sukh-P Awaiting requested review from Sukh-P

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdudfield @devsjc