Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ecmwf to new nwp-consumer #734

Merged
merged 2 commits into from
Jan 13, 2025
Merged

update ecmwf to new nwp-consumer #734

merged 2 commits into from
Jan 13, 2025

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Jan 13, 2025 •
edited
Loading

Pull Request

Description

Update new nwp-consumer for ECMWF

Already updated dashbaord and PVnet app, to 2.4.19 and 2b68542

#697

How Has This Been Tested?

  • CI tests

  • tested on dev

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield requested a review from devsjc January 13, 2025 13:19
@peterdudfield peterdudfield marked this pull request as ready for review January 13, 2025 13:19
devsjc
devsjc approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@devsjc devsjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peterdudfield peterdudfield merged commit 766ed8e into main Jan 13, 2025
5 checks passed
@peterdudfield peterdudfield deleted the uk-ecmwf-new-consumer branch January 13, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsjc devsjc devsjc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdudfield @devsjc