Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove satellite datapipe, remove metnet #345

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

remove satellite datapipe, remove metnet #345

wants to merge 10 commits into from

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Jul 25, 2024 •
edited
Loading

Pull Request

Description

  • Remove satellite datapipe
  • remove all metnet related stuff, as we are not using it
  • added a new FakeIter datapipe to be used to join loading satellite data into current datapipes. Later on we can change each remove each datapipe and use FakeIter if we need to

This is a potential idea of how to do it iteratively with #342

How Has This Been Tested?

CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield marked this pull request as ready for review July 30, 2024 12:47
@peterdudfield peterdudfield requested a review from dfulu July 30, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfulu dfulu Awaiting requested review from dfulu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@peterdudfield