-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python3.12 #93
Comments
@peterdudfield sir, can i take this one ? |
@peterdudfield sir, I want to work on this. I'll start by running the project's examples locally using Python 3.12 to ensure compatibility and identify any potential issues. I will be glad to get the opportunity to work on this project. I'm an Electrical Engineer passionate about climate change and I am currently working with python as I am currently taking a machine learning course in my school and also learning data science with python on World Quant University. This project is something I want to contribute to and also learn more from. Thank you sir |
I'd like to tackle this issue. After attempting to run the test in Python 3.12, it appears that there's an issue with compatibility. The test didn't execute as expected due to pv-site-prediction package not being supported in Python 3.12. |
@peterdudfield, I think I understand what is going wrong here! :) I tried to update the dependency versioning in the pyproject.toml, but unfortunately some dependencies' latest packages still do not support 3.12 yet! I've worked quite a bit on CI/CD, and I'd be happy to add 3.12 tests to the CI. It should work eventually when the dependencies catch up, but it might show you some failures in the shorter timespan. Should I go ahead and add tests for 3.12 to CI? |
Hi @shlok191! Thanks for pointing this out. You are correct in that currently pv-site-prediction is bound by:
Can you find out which of the dependencies dont support 3.12 yet? Before we proceed with adding the 3.12 tests, let's take a step back and review our current dependencies to pinpoint which ones specifically lack support for Python 3.12. :) |
@zakwatts, absolutely! It is the pandas-stubs library that does not support python 3.12 yet. There could potentially be more (the dependency check could just be failing at the first dependency error), but from what I see it is this library only. Here is the official error: I really like what you all are working on, and I would love to help out more! Let me know if there's anything else for me to possibly help out with :) |
@zakwatts how did you go about finding what the issue, essentially i'm curious about the techniques you used to identify and isolate the issue to that specific library? |
@peterdudfield I think @zakwatts was right in the See here for reference https://pypi.org/project/pandas-stubs/1.5.2.221213/ Check https://pypi.org/project/pandas-stubs/#history I'll keep checking the other dependencies to see if any are still outdated and not compatible with the latest Python 3.12, since there's alot of them it'll take awhile |
Hi @Clemo97! Thanks for picking this up. It was a little while ago when I did this, but essentially as i work on the pv-site-predicition model i think I knew that this was likely causing some dependency problems. Thanks for letting us know about the new version of pandas-stubs! When i get the chance i should be able to update this at somepoint and hopefully that should allow us to update Open Quartz to python 3.12. Thanks! |
@zakwatts Since the issue exists in pv-site-prediction, I believe the issue should be addressed there. |
Detailed Description
Would be good if this ran for python3.12
Possible Implementation
The text was updated successfully, but these errors were encountered: