Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs to make regime optional #359

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update docs to make regime optional #359

wants to merge 1 commit into from

Conversation

braddf
Copy link
Contributor

@braddf braddf commented Sep 10, 2024

Pull Request

Description

gsp/pvlive/all route docs said it should default regime to in-day if not specified; in reality, it defaults to None and gives us the expected behaviour of returning PV Live Updated where available, with Estimated values as fallback.

How Has This Been Tested?

  • Locally

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@braddf braddf added the documentation Improvements or additions to documentation label Sep 10, 2024
@braddf braddf self-assigned this Sep 10, 2024
peterdudfield
peterdudfield approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@peterdudfield peterdudfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also do this for the pvlive gsp route too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterdudfield peterdudfield peterdudfield approved these changes

Assignees

@braddf braddf

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@braddf @peterdudfield