Skip to content

feat: add hotkey validation system #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ritikpal1122
Copy link

"feat: add hotkey validation system with comprehensive tests"
"feat: integrate hotkey validation with TUI components"

@kujtimiihoxha Can you please check this once ?

@ritikpal1122
Copy link
Author

hey @kujtimiihoxha can you please check this ?

@jesses-code-adventures
Copy link

@ritikpal1122 you may want to look at the existing cmd/schema/README.md for some information about the current approach to config, and follow the code called in cmd/schema/main.go to get a sense for how you'd add hotkey mapping to the current config.

Forgive me if I'm misunderstanding your PR, but I can't see how it integrates with the existing config, or how it allows a user that isn't building opencode from source to configure their hotkeys.

@ritikpal1122
Copy link
Author

ok sure @jesses-code-adventures Can you explain more are my changes completely wrong

@adamdottv
Copy link
Contributor

we're very interested in configurable keymappings, but the configuration should be housed within the existing config file, not a separate yaml file

@ritikpal1122
Copy link
Author

Sure i'll Update (:

@ritikpal1122
Copy link
Author

CLosing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants