Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide signed url for uploaded expense files #10500

Merged
merged 32 commits into from
Jan 6, 2025

Conversation

hdiniz
Copy link
Contributor

@hdiniz hdiniz commented Nov 27, 2024

@hdiniz hdiniz self-assigned this Nov 27, 2024
@hdiniz hdiniz force-pushed the provide-signed-url-for-uploaded-expense-files branch from 994d54c to 001ee3c Compare November 28, 2024 19:57
@hdiniz hdiniz requested a review from Betree November 28, 2024 20:32
@hdiniz hdiniz marked this pull request as ready for review November 28, 2024 20:32
Copy link
Member

@Betree Betree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's serving a critical feature with sensitive permissions, we need to add proper tests for the /files/... controller.

@hdiniz hdiniz requested a review from Betree November 29, 2024 19:43
@@ -1,3 +1,15 @@
<style>
.preview {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if classes are scoped in our email setup (we're using juice to inline CSS). If not, maybe use something that is less likely to clash (e.g. expense-item-preview)

@hdiniz
Copy link
Contributor Author

hdiniz commented Dec 5, 2024

Thanks for your review on this @Betree, I have made changes according to our discussion so far, but its still not complete.
One missing piece here is a strategy for dealing with uploaded files used in expense invites, I will look into it next.

@hdiniz hdiniz force-pushed the provide-signed-url-for-uploaded-expense-files branch from 2ad64d9 to 8a9d0e0 Compare December 11, 2024 19:31
@hdiniz hdiniz requested a review from Betree December 18, 2024 13:22
Copy link
Member

@Betree Betree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with the draft status handling 👍

Looking good overall, I expressed some concerns below but they're non-blocking. Let's try to deploy & test this in production before the holidays.

@hdiniz hdiniz force-pushed the provide-signed-url-for-uploaded-expense-files branch from 02ccd18 to ab650e2 Compare January 6, 2025 13:01
@hdiniz hdiniz merged commit 5165f42 into main Jan 6, 2025
20 checks passed
@hdiniz hdiniz deleted the provide-signed-url-for-uploaded-expense-files branch January 6, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants