-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide signed url for uploaded expense files #10500
Conversation
994d54c
to
001ee3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's serving a critical feature with sensitive permissions, we need to add proper tests for the /files/...
controller.
migrations/20241127165812-add-expense-attachments-url-indexes.js
Outdated
Show resolved
Hide resolved
templates/partials/expense-items.hbs
Outdated
@@ -1,3 +1,15 @@ | |||
<style> | |||
.preview { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if classes are scoped in our email setup (we're using juice to inline CSS). If not, maybe use something that is less likely to clash (e.g. expense-item-preview
)
Thanks for your review on this @Betree, I have made changes according to our discussion so far, but its still not complete. |
2ad64d9
to
8a9d0e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job with the draft status handling 👍
Looking good overall, I expressed some concerns below but they're non-blocking. Let's try to deploy & test this in production before the holidays.
Co-authored-by: Benjamin Piouffle <[email protected]>
Co-authored-by: Benjamin Piouffle <[email protected]>
Co-authored-by: Benjamin Piouffle <[email protected]>
Co-authored-by: Benjamin Piouffle <[email protected]>
02ccd18
to
ab650e2
Compare
Related opencollective/opencollective#6351