ContributionFlow: Information requirement resolvers #10661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Betree
approved these changes
Feb 5, 2025
Comment on lines
+24
to
+35
| totalContributedToHost: { | ||
| buildLoader: ({ | ||
| since, | ||
| hostId, | ||
| }: { | ||
| hostId: number; | ||
| since: Date | string; | ||
| }): DataLoader< | ||
| number, | ||
| { CollectiveId: number; amount: number; currency: SupportedCurrency; HostCollectiveId: number } | ||
| > => { | ||
| const key = compact([hostId, since]).join('-'); |
There was a problem hiding this comment.
I don't understand the benefit of using buildLoader rather than just a regular loader here?
There was a problem hiding this comment.
Not sure if I'm tripping, but isn't this required for sharing the since and hostId parameters across multiple DataLoader calls.
kewitz
force-pushed
the
refact/policies
branch
from
a8c7992 to
6648f5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds CONTRIBUTOR_INFO_THRESHOLDS policy and ContributorProfile.totalContributedToHost resolver.