Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(Expense form): Account balance payout method fixes #11065

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gustavlrsn
Copy link
Member

Resolves opencollective/opencollective#7858

Description

  • Always show "Account balance" as a proper option, even if it has not been used before
  • Hide the "New payout method" option if no options exist (as it could have been included as a proper card)
  • Disable editing/deleting of "Account balance" payout methods, since there is nothing to edit or sensitive information to delete

Copy link

vercel bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opencollective-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 0:54am

...pick(form.options, ['supportedPayoutMethods', 'host', 'loggedInAccount', 'payee']),
touchedNewPayoutMethodName: form.touched.newPayoutMethod?.name,
...pick(form.options, ['newPayoutMethodTypes', 'payoutMethods', 'host', 'loggedInAccount', 'payee']),
touchedNewPayoutMethodName: form.touched.newPayoutMethod?.name, // can be removed now?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Comment on lines +1376 to +1381
id: '__newAccountBalancePayoutMethod',
type: PayoutMethodType.ACCOUNT_BALANCE,
// name: 'Account balance',
data: { currency: host.currency },
// data: { currency: host.currency },
isSaved: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
id: '__newAccountBalancePayoutMethod',
type: PayoutMethodType.ACCOUNT_BALANCE,
// name: 'Account balance',
data: { currency: host.currency },
// data: { currency: host.currency },
isSaved: true,
id: '__newAccountBalancePayoutMethod',
type: PayoutMethodType.ACCOUNT_BALANCE,
data: { currency: host.currency },
isSaved: true,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Account Balance Payout Method Issues - New Expense Flow
2 participants