Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receipt: better support for host currency #973

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Conversation

Betree
Copy link
Member

@Betree Betree commented Nov 24, 2023

Resolve opencollective/opencollective#7127

Also configured unit/snapshot testing

@Betree Betree self-assigned this Nov 24, 2023
Copy link

vercel bot commented Nov 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opencollective-pdf ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 24, 2023 11:17am

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (26a3ad5) 20.00% compared to head (a3f927b) 65.59%.

❗ Current head a3f927b differs from pull request most recent head 53688f0. Consider uploading reports for the commit 53688f0 to get more accurate results

Files Patch % Lines
components/Receipt.js 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #973       +/-   ##
===========================================
+ Coverage   20.00%   65.59%   +45.59%     
===========================================
  Files           1       14       +13     
  Lines          45      311      +266     
  Branches       18      126      +108     
===========================================
+ Hits            9      204      +195     
- Misses         24       88       +64     
- Partials       12       19        +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Betree Betree marked this pull request as ready for review November 27, 2023 07:31
@Betree Betree merged commit 346753a into main Dec 8, 2023
6 checks passed
@Betree Betree deleted the enhancement/host-currency branch December 8, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Donation Receipt Appears in Host Currency Instead of Collective Currency
2 participants