[ConvertToRISCV] Fallback to Linalg lowering if xdsl-opt fails
#110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While we are not able to leverage snitch's SSR and FREP extension if `xdsl-opt` fails, our schedule and use of L1 memory should generally lead to performance improvements over the LLVM backend's kernel. This PR therefore changes the mechanism when `xdsl-opt` fails to inline the linalg operation and erase the `quidditch_snitch.memref.microkernel`, instead of the current behavior of discarding the kernel entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we are not able to leverage snitch's SSR and FREP extension if
xdsl-optfails, our schedule and use of L1 memory should generally lead to performance improvements over the LLVM backend's kernel. This PR therefore changes the mechanism whenxdsl-optfails to inline the linalg operation and erase thequidditch_snitch.memref.microkernel, instead of the current behavior of discarding the kernel entirely.