[PromoteToL1] Fix dominance bug #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pass would previously create invalid IR by always replacing a tensor value with the promoted tensor despite its insertion point being before a compute operation. If another operation before the compute operation would have a use of the tensor it'd get replaced despite being illegal. The fix is to simply not replace the value of the tensor but rather the operand use. CSE should clean up any redundancy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pass would previously create invalid IR by always replacing a tensor value with the promoted tensor despite its insertion point being before a compute operation. If another operation before the compute operation would have a use of the tensor it'd get replaced despite being illegal.
The fix is to simply not replace the value of the tensor but rather the operand use. CSE should clean up any redundancy.